Re: [Qemu-devel] [PATCH v2 0/9] synchronization profiler

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/9] synchronization profiler

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
5f5c9f4814 hmp-commands-info: add sync-profile
dda3cae528 hmp-commands: add sync-profile
88d0f93fe4 vl: add -enable-sync-profile
15359bc24a tests/atomic_add-bench: add -p to enable sync profiler
c03b816ed4 qsp: track BQL callers explicitly
a213737f84 qsp: support call site coalescing
6edc020b67 qsp: add qsp_reset
0b7317100b qsp: add sort_by option to qsp_report
2b55a85381 qsp: QEMU's Synchronization Profiler

=== OUTPUT BEGIN ===
Checking PATCH 1/9: qsp: QEMU's Synchronization Profiler...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

ERROR: spaces required around that '*' (ctx:WxV)
#664: FILE: util/qsp.c:296:
+    static void func_(type_ *obj, const char *file, int line)           \
                             ^

ERROR: spaces required around that '*' (ctx:WxV)
#679: FILE: util/qsp.c:311:
+    static int func_(type_ *obj, const char *file, int line)            \
                            ^

ERROR: spaces required around that '-' (ctx:VxV)
#871: FILE: util/qsp.c:503:
+    entry->time_s = e->ns * 1e-9;
                               ^

ERROR: spaces required around that '-' (ctx:VxV)
#916: FILE: util/qsp.c:548:
+           "", e->time_s, e->n_acqs, e->ns_avg * 1e-3);
                                                    ^

total: 4 errors, 1 warnings, 850 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/9: qsp: add sort_by option to qsp_report...
Checking PATCH 3/9: qsp: add qsp_reset...
Checking PATCH 4/9: qsp: support call site coalescing...
ERROR: spaces required around that '-' (ctx:VxV)
#199: FILE: util/qsp.c:707:
+                               e->time_s, e->n_acqs, e->ns_avg * 1e-3);
                                                                    ^

total: 1 errors, 0 warnings, 193 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/9: qsp: track BQL callers explicitly...
Checking PATCH 6/9: tests/atomic_add-bench: add -p to enable sync profiler...
Checking PATCH 7/9: vl: add -enable-sync-profile...
Checking PATCH 8/9: hmp-commands: add sync-profile...
Checking PATCH 9/9: hmp-commands-info: add sync-profile...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden