Re: [Qemu-devel] [PULL 0/6] Linux user for 3.1 patches

[Laurent Vivier]

Le 20/08/2018 à 16:44, Peter Maydell a écrit :
> On 19 August 2018 at 23:17, Laurent Vivier <address@hidden> wrote:
>> The following changes since commit 0abaa41d936becd914a16ee1fe2a981d96d19428:
>>
>>   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' 
>> into staging (2018-08-17 09:46:00 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/linux-user-for-3.1-pull-request
>>
>> for you to fetch changes up to c072a24c11e713f14ab969799433218d8ceebe19:
>>
>>   linux-user: add QEMU_IFLA_INFO_KIND nested type for tun (2018-08-20 
>> 00:11:06 +0200)
>>
>> ----------------------------------------------------------------
>> linux-user fixes:
>> - netlink fixes (add missing types, fix MSG_TRUNC)
>> - sh4 fix (tcg state)
>> - sparc32plus fix (truncate address space to 32bit)
>> - add x86_64 binfmt data
>>
>> ----------------------------------------------------------------

Hi

> Hi -- I'm afraid this doesn't build on my ppc64 test box:
> 
> /home/pm215/qemu/linux-user/syscall.c: In function
> ‘host_to_target_data_route_rtattr’:
> /home/pm215/qemu/linux-user/syscall.c:2719:10: error: ‘RTA_PREF’
> undeclared (first use in this function)
>      case RTA_PREF:

I've tested this on ppc64 box too before the p-l, and it has worked. The
macro is in /usr/include/linux/rtnetlink.h that comes with
kernel-headers-4.17.14-3.fc28.ppc64.

I've checked in the kernel sources and the macro appears in the file in
kernel v4.1 (c78ba6d64c78 ipv6: expose RFC4191 route preference via
rtnetlink).

I'm going to fix that. Thank you.

Laurent