Re: [Qemu-devel] [PATCH 1/5] tcg: Split CONFIG_ATOMIC128

[Richard Henderson]

On 08/17/2018 09:42 AM, Emilio G. Cota wrote:
>> +/* Through gcc 8, aarch64 has no support for 128-bit at all.  */
>> +static inline Int128 atomic16_cmpxchg(Int128 *ptr, Int128 cmp, Int128 new)
>> +{
>> +    uint64_t cmpl = cmp, cmph = cmp >> 64;
>> +    uint64_t newl = new, newh = new >> 64;
> Here I'd use int128_getlo/hi, since we're not checking for
> CONFIG_INT128 (I'm thinking of old compilers here)

I suppose, but this is aarch64 -- there are no really old compilers.
The oldest is probably gcc 4.8, which already has __int128_t.

Thanks for the other catches too.


r~