Re: [Qemu-devel] [libvirt] [PATCH] Remove deprecated -balloon option

[Daniel P . Berrangé]

On Tue, Aug 21, 2018 at 12:05:30PM +0200, Thomas Huth wrote:
> The "-balloon" option has been replaced by "-device virtio-balloon".
> It's been marked as deprecated since two releases, and nobody
> complained, so let's remove it now.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  docs/virtio-balloon-stats.txt |  6 +++---
>  qemu-deprecated.texi          |  5 -----
>  qemu-options.hx               | 10 ----------
>  vl.c                          | 36 ------------------------------------
>  4 files changed, 3 insertions(+), 54 deletions(-)

Confirmed that this is no longer used by libvirt, as we assume we have
new enough QEMU for -device

  Reviewed-by: Daniel P. Berrangé <address@hidden>


> 
> diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt
> index 9985e1d..1732cc8 100644
> --- a/docs/virtio-balloon-stats.txt
> +++ b/docs/virtio-balloon-stats.txt
> @@ -61,9 +61,9 @@ It's also important to note the following:
>     respond to the request the timer will never be re-armed, which has
>     the same effect as disabling polling
>  
> -Here are a few examples. QEMU is started with '-balloon virtio', which
> -generates '/machine/peripheral-anon/device[1]' as the QOM path for the
> -balloon device.
> +Here are a few examples. QEMU is started with '-device virtio-balloon',
> +which generates '/machine/peripheral-anon/device[1]' as the QOM path for
> +the balloon device.

We should try to get in the habit of changing the docs at the time we
deprecate stuff. I keep forgetting todo this myself too :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|