[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim |
Date: |
Wed, 22 Aug 2018 13:55:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-17 21:04, John Snow wrote:
> Change the manual deferment to commit_complete into the implicit
> callback to job_exit, renaming commit_complete to commit_exit.
>
> This conversion does change the timing of when job_completed is
> called to after the bdrv_replace_node and bdrv_unref calls, which
> could have implications for bjob->blk which will now be put down
> after this cleanup.
>
> Kevin highlights that we did not take any permissions for that backend
> at job creation time, so it is safe to reorder these operations.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/commit.c | 20 ++++----------------
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/block/commit.c b/block/commit.c
> index 4a17bb73ec..93c3b6a39e 100644
> --- a/block/commit.c
> +++ b/block/commit.c
[...]
> @@ -93,8 +87,8 @@ static void commit_complete(Job *job, void *opaque)
>
> if (!job_is_cancelled(job) && ret == 0) {
> /* success */
> - ret = bdrv_drop_intermediate(s->commit_top_bs, base,
> - s->backing_file_str);
> + job->ret = bdrv_drop_intermediate(s->commit_top_bs, base,
> + s->backing_file_str);
This makes me ask myself why .exit() doesn't just return an int, like
.run(). And takes an Error **.
Max
> } else {
> /* XXX Can (or should) we somehow keep 'consistent read' blocked even
> * after the failed/cancelled commit job is gone? If we already wrote
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim, John Snow, 2018/08/17
Re: [Qemu-devel] [PATCH 4/7] block/commit: utilize job_exit shim,
Max Reitz <=
[Qemu-devel] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/17
Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/22
Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim, Max Reitz, 2018/08/25
Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim, John Snow, 2018/08/27
Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim, Max Reitz, 2018/08/29