Re: [Qemu-devel] [PATCH] slirp: Implement RFC2132 TFTP server name

[Samuel Thibault]

Hello,

Fam Zheng, le ven. 24 août 2018 21:53:12 +0800, a ecrit:
>                            const char *vnameserver, const char *vnameserver6,
>                            const char *smb_export, const char *vsmbserver,
>                            const char **dnssearch, const char *vdomainname,
> +                          const char *tftp_server_name,

I'd say rather put it between the vhostname and tftp_export parameters.

> @@ -321,6 +322,9 @@ Slirp *slirp_init(int restricted, bool in_enabled, struct 
> in_addr vnetwork,
>      slirp->vdhcp_startaddr = vdhcp_start;
>      slirp->vnameserver_addr = vnameserver;
>      slirp->vnameserver_addr6 = vnameserver6;
> +    if (tftp_server_name) {
> +        slirp->tftp_server_name = g_strdup(tftp_server_name);
> +    }

I'd say do not bother testing for tftp_server_name != NULL, just always
use g_strdup, as is done for other values.

Samuel