[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/9] monitor: consitify qmp_send_response() Q
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/9] monitor: consitify qmp_send_response() QDict argument |
Date: |
Mon, 27 Aug 2018 09:36:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-25 15:57, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 021c11b1bf..a1db4db487 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -503,9 +503,9 @@ int monitor_fprintf(FILE *stream, const char *fmt, ...)
> return 0;
> }
>
> -static void qmp_send_response(Monitor *mon, QDict *rsp)
> +static void qmp_send_response(Monitor *mon, const QDict *rsp)
> {
> - QObject *data = QOBJECT(rsp);
> + const QObject *data = QOBJECT(rsp);
> QString *json;
>
> json = mon->flags & MONITOR_USE_PRETTY ? qobject_to_json_pretty(data) :
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v3 0/9] monitor: various code simplification and fixes, Marc-André Lureau, 2018/08/25
- [Qemu-devel] [PATCH v3 1/9] monitor: consitify qmp_send_response() QDict argument, Marc-André Lureau, 2018/08/25
- Re: [Qemu-devel] [PATCH v3 1/9] monitor: consitify qmp_send_response() QDict argument,
Thomas Huth <=
- [Qemu-devel] [PATCH v3 2/9] qmp: constify qmp_is_oob(), Marc-André Lureau, 2018/08/25
- [Qemu-devel] [PATCH v3 3/9] Revert "qmp: isolate responses into io thread", Marc-André Lureau, 2018/08/25
- [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Marc-André Lureau, 2018/08/25
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Peter Xu, 2018/08/27
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Markus Armbruster, 2018/08/28
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Peter Xu, 2018/08/28
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Markus Armbruster, 2018/08/29
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Peter Xu, 2018/08/29
- Re: [Qemu-devel] [PATCH v3 4/9] monitor: no need to save need_resume, Markus Armbruster, 2018/08/29