[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/9] block/mirror: utilize job_exit shim
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/9] block/mirror: utilize job_exit shim |
Date: |
Mon, 27 Aug 2018 12:30:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:08, John Snow wrote:
> Change the manual deferment to mirror_exit into the implicit
> callback to job_exit and the mirror_exit callback.
>
> This does change the order of some bdrv_unref calls and job_completed,
> but thanks to the new context in which we call .exit, this is safe to
> defer the possible flushing of any nodes to the job_finalize_single
> cleanup stage.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/mirror.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
Looks good, but the comment about why @src is bdrv_ref()'ed needs to be
updated.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/9] jobs: Job Exit Refactoring Pt 1, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 8/9] jobs: remove ret argument to job_completed; privatize it, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 2/9] jobs: canonize Error object, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 7/9] block/backup: make function variables consistently named, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 5/9] block/mirror: utilize job_exit shim, John Snow, 2018/08/23
- Re: [Qemu-devel] [PATCH v2 5/9] block/mirror: utilize job_exit shim,
Max Reitz <=
- [Qemu-devel] [PATCH v2 6/9] jobs: utilize job_exit shim, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 9/9] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 4/9] block/commit: utilize job_exit shim, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 1/9] jobs: change start callback to run callback, John Snow, 2018/08/23