[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/13] tests/test-blockjob: remove exit callb
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/13] tests/test-blockjob: remove exit callback |
Date: |
Mon, 27 Aug 2018 15:41:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:22, John Snow wrote:
> We remove the exit callback and the completed boolean along with it.
> We can simulate it just fine by waiting for the job to defer to the
> main loop, and then giving it one final kick to get the main loop
> portion to run.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/test-blockjob.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
Hm, well, sure, but I'd think deferred_to_main_loop is an internal
attribute. Considering this is just a test, it doesn't matter, though, so:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/13] jobs: jobs: Job Exit Refactoring Pt 2, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 08/13] tests/test-blockjob: remove exit callback, John Snow, 2018/08/23
- Re: [Qemu-devel] [PATCH v2 08/13] tests/test-blockjob: remove exit callback,
Max Reitz <=
- [Qemu-devel] [PATCH v2 01/13] block/commit: add block job creation flags, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 03/13] block/stream: add block job creation flags, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 06/13] block/commit: refactor stream to use job callbacks, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 02/13] block/mirror: add block job creation flags, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 10/13] qapi/block-commit: expose new job properties, John Snow, 2018/08/23