Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

[Daniel P . Berrangé]

On Tue, Aug 28, 2018 at 12:20:02PM +0200, Gerd Hoffmann wrote:
> On Tue, Aug 28, 2018 at 09:19:20AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Aug 27, 2018 at 12:53:21PM +0200, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > > The only way we can stop using "-device sga" is if we either have
> > > > something explicit in the XML saying whether to use it or not, or
> > > > alternatively have some indicator associated with the next versioned
> > > > machine type that we can hook off.
> > > 
> > > How does libvirt query the machine type properties?
> > 
> > libvirt is able to query properties against i440FX-pcihost and
> > q35-pcihost devices - currently we only look for one prop:
> > 
> > static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsI440FXPCIHost[] 
> > = {
> >     { "pci-hole64-size", QEMU_CAPS_I440FX_PCI_HOLE64_SIZE },
> > };
> > 
> > static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsQ35PCIHost[] = {
> >     { "pci-hole64-size", QEMU_CAPS_Q35_PCI_HOLE64_SIZE },
> > };
> > 
> > Not sure if that's the kind of thing you're looking for ?
> 
> Looking for way for libvirt to figure whenever a specific machine type
> has sga deprecated or not.  So, if libvirt can query device properties,
> can we just add a "deprecated" property to sga and flip that to true for
> 3.1+ machine types?

Unfortunately not, because libvirt probes everthing with '-machine none'

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|