[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] block: Allow changing 'discard' on reopen
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] block: Allow changing 'discard' on reopen |
Date: |
Wed, 29 Aug 2018 13:44:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-26 16:09, Alberto Garcia wrote:
> 'discard' is one of the basic BlockdevOptions available for all
> drivers, but it's silently ignored by bdrv_reopen_prepare/commit(), so
> the user cannot change it and doesn't get an error explaining that it
> can't be changed.
>
> This should update the discard setting, but does nothing:
>
> (qemu) qemu-io virtio0 "reopen -o discard=on"
>
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/block.c b/block.c
> index 804d557608..21f1eb9cd1 100644
> --- a/block.c
> +++ b/block.c
> @@ -3178,6 +3178,15 @@ int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
> BlockReopenQueue *queue,
>
> update_flags_from_options(&reopen_state->flags, opts);
>
> + value = qemu_opt_get(opts, "discard");
> + if (value != NULL) {
> + if (bdrv_parse_discard_flags(value, &reopen_state->flags) != 0) {
> + error_setg(errp, "Invalid discard option");
> + ret = -EINVAL;
> + goto error;
> + }
> + }
> +
Let me add a:
Reviewed-by: Max Reitz <address@hidden>
Although I think it might need a _del.
signature.asc
Description: OpenPGP digital signature