[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 07/10] tests: add qmp/qom-set-without-value test
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v4 07/10] tests: add qmp/qom-set-without-value test |
Date: |
Wed, 29 Aug 2018 15:40:40 +0200 |
test_qom_set_without_value() is about a bug in infrastructure used by
the QMP core, fixed in commit c489780203. We covered the bug in
infrastructure unit tests (commit bce3035a44). I wrote that test
earlier, to cover QMP level as well, the test could go into qmp-test.
Signed-off-by: Marc-André Lureau <address@hidden>
---
tests/qmp-test.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 4ae2245484..fdfe73b6d2 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -348,6 +348,23 @@ static void test_qmp_preconfig(void)
qtest_quit(qs);
}
+static void test_qom_set_without_value(void)
+{
+ QTestState *qts;
+ QDict *ret;
+
+ qts = qtest_init(common_args);
+
+ ret = qtest_qmp(qts, "{'execute': 'qom-set', 'arguments':"
+ " { 'path': '/machine', 'property': 'rtc-time' } }");
+ g_assert_nonnull(ret);
+
+ g_assert_cmpstr(get_error_class(ret), ==, "GenericError");
+
+ qobject_unref(ret);
+ qtest_quit(qts);
+}
+
int main(int argc, char *argv[])
{
g_test_init(&argc, &argv, NULL);
@@ -355,6 +372,7 @@ int main(int argc, char *argv[])
qtest_add_func("qmp/protocol", test_qmp_protocol);
qtest_add_func("qmp/oob", test_qmp_oob);
qtest_add_func("qmp/preconfig", test_qmp_preconfig);
+ qtest_add_func("qmp/qom-set-without-value", test_qom_set_without_value);
return g_test_run();
}
--
2.19.0.rc0.48.gb9dfa238d5
- [Qemu-devel] [PATCH v4 01/10] monitor: consitify qmp_send_response() QDict argument, (continued)
- [Qemu-devel] [PATCH v4 01/10] monitor: consitify qmp_send_response() QDict argument, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 03/10] Revert "qmp: isolate responses into io thread", Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 04/10] monitor: no need to save need_resume, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 05/10] json-lexer: make it safe to call destroy multiple times, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 06/10] tests: add qmp/object-add-without-props test, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 08/10] tests: add a qmp success-response test, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 07/10] tests: add qmp/qom-set-without-value test,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v4 09/10] qga: process_event() simplification, Marc-André Lureau, 2018/08/29
- [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec, Marc-André Lureau, 2018/08/29
- Re: [Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes, Markus Armbruster, 2018/08/30