[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when hinted address is too small |
Date: |
Thu, 30 Aug 2018 09:53:11 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* David Hildenbrand (address@hidden) wrote:
> The "at" should actually be a "before".
> if (new_addr < address_space_start)
> -> "can't add memory ... before... $address_space_start"
>
> So it looks similar to the other check
> } else if ((new_addr + size) > address_space_end)
> -> "can't add memory ... beyond..."
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/mem/memory-device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 6de4f70bb4..efacbc2a7d 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -146,7 +146,8 @@ uint64_t memory_device_get_free_addr(MachineState *ms,
> const uint64_t *hint,
> new_addr = *hint;
> if (new_addr < address_space_start) {
> error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
> - "] at 0x%" PRIx64, new_addr, size,
> address_space_start);
> + "] before 0x%" PRIx64, new_addr, size,
> + address_space_start);
OK, so
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> return 0;
> } else if ((new_addr + size) > address_space_end) {
That comparison (that's already there) doesn't look wrap-safe?
Dave
> error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 00/20] memory-device: complete refactoring + virtio-pmem, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 02/20] memory-device: use memory device terminology in error messages, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when hinted address is too small, David Hildenbrand, 2018/08/29
- Re: [Qemu-devel] [PATCH v2 01/20] memory-device: fix error message when hinted address is too small,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v2 03/20] memory-device: introduce separate config option, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 04/20] memory-device: get_region_size()/get_plugged_size() might fail, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 05/20] memory-device: convert get_region_size() to get_memory_region(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 06/20] memory-device: document MemoryDeviceClass, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 07/20] memory-device: add device class function set_addr(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 08/20] pc-dimm: implement memory device class function set_addr(), David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 09/20] memory-device: complete factoring out pre_plug handling, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 10/20] memory-device: complete factoring out plug handling, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 11/20] memory-device: complete factoring out unplug handling, David Hildenbrand, 2018/08/29
- [Qemu-devel] [PATCH v2 12/20] memory-device: trace when pre_assigning/assigning/unassigning addresses, David Hildenbrand, 2018/08/29