[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] io: file descriptor not initialized in qio_chan
From: |
Liam Merwick |
Subject: |
[Qemu-devel] [PATCH 7/8] io: file descriptor not initialized in qio_channel_command_new_spawn() |
Date: |
Thu, 30 Aug 2018 16:47:10 +0100 |
Incorrect checking of flags could result in uninitialized
file descriptor being used.
Signed-off-by: Liam Merwick <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Reviewed-by: Mark Kanda <address@hidden>
---
io/channel-command.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/io/channel-command.c b/io/channel-command.c
index 3e7eb17eff54..38deb687da21 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -59,10 +59,10 @@ qio_channel_command_new_spawn(const char *const argv[],
flags = flags & O_ACCMODE;
- if (flags == O_RDONLY) {
+ if ((flags & O_RDONLY) == O_RDONLY) {
stdinnull = true;
}
- if (flags == O_WRONLY) {
+ if ((flags & O_WRONLY) == O_WRONLY) {
stdoutnull = true;
}
--
1.8.3.1
[Qemu-devel] [PATCH 5/8] block: Fix potential Null pointer dereferences in vvfat.c, Liam Merwick, 2018/08/30
[Qemu-devel] [PATCH 1/8] configure: Provide option to explicitly disable AVX2, Liam Merwick, 2018/08/30