[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/9] jobs: canonize Error object |
Date: |
Fri, 31 Aug 2018 08:08:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/29/2018 08:57 PM, John Snow wrote:
>> Jobs presently use both an Error object in the case of the create job,
>> and char strings in the case of generic errors elsewhere.
>>
>> Unify the two paths as just j->err, and remove the extra argument from
>> job_completed. The integer error code for job_completed is kept for now,
>> to be removed shortly in a separate patch.
>>
>> Signed-off-by: John Snow <address@hidden>
>> ---
>
>> +++ b/job.c
>
>> @@ -666,8 +666,8 @@ static void job_update_rc(Job *job)
>> job->ret = -ECANCELED;
>> }
>> if (job->ret) {
>> - if (!job->error) {
>> - job->error = g_strdup(strerror(-job->ret));
>> + if (!job->err) {
>> + error_setg(&job->err, "%s", g_strdup(strerror(-job->ret)));
>
> Memleak. Drop the g_strdup(), and just directly pass strerror()
> results to error_setg(). (I guess we can't quite use
> error_setg_errno() unless we add additional text beyond the strerror()
> results).
Adding such text might well be an improvement. I'm not telling you to
do so (not having looked at the context myself), just to think about it.
> With that fixed,
> Reviewed-by: Eric Blake <address@hidden>
- [Qemu-devel] [PATCH v3 0/9] jobs: Job Exit Refactoring Pt 1, John Snow, 2018/08/29
- [Qemu-devel] [PATCH v3 5/9] block/mirror: utilize job_exit shim, John Snow, 2018/08/29
- [Qemu-devel] [PATCH v3 7/9] block/backup: make function variables consistently named, John Snow, 2018/08/29
- [Qemu-devel] [PATCH v3 8/9] jobs: remove ret argument to job_completed; privatize it, John Snow, 2018/08/29
- [Qemu-devel] [PATCH v3 9/9] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/29
- [Qemu-devel] [PATCH v3 4/9] block/commit: utilize job_exit shim, John Snow, 2018/08/29