[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests |
|
Date: |
Mon, 10 Sep 2018 10:37:47 -0400 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Sep 10, 2018 at 12:00:56 +0100, Alex Bennée wrote:
> Emilio G. Cota <address@hidden> writes:
> > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > index 87c81d1dcc..363f133101 100644
> > --- a/tests/Makefile.include
> > +++ b/tests/Makefile.include
> > @@ -657,6 +657,9 @@ tests/qht-bench$(EXESUF): tests/qht-bench.o
> > $(test-util-obj-y)
> > tests/test-bufferiszero$(EXESUF): tests/test-bufferiszero.o
> > $(test-util-obj-y)
> > tests/atomic_add-bench$(EXESUF): tests/atomic_add-bench.o
> > $(test-util-obj-y)
> >
> > +tests/fp/%:
> > + $(MAKE) -C $(dir $@) $(notdir $@)
> > +
>
> This isn't enough to cause the build to be included in make check or
> indeed be run. Perhaps that should be included in a new patch in the
> series?
Yes I figured we should fix the reported errors first -- otherwise
we'll knowingly break the integration tests.
Emilio