[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal |
Date: |
Tue, 11 Sep 2018 12:31:05 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Sep 11, 2018 at 07:33:08AM -0700, Richard Henderson wrote:
> On 09/05/2018 08:19 AM, Eduardo Habkost wrote:
> > Currently there's no way to make configure not try to use the
> > system-provided capstone library using pkgconfig.
>
> Certainly there is.
>
> >
> > Add support to --enable-capstone=internal option to make QEMU not
> > use the system-provided library automatically.
Oops, the commit message is inaccurate: we can prevent
./configure from trying the system library, but there's no way to
make it avoid using git submodule at the same time.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > configure | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/configure b/configure
> > index 58862d2ae8..34ed00f6d9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1431,6 +1431,8 @@ for opt do
> > + --enable-capstone[=LOCATION]
> > + Where to look for capstone library.
> > + Supported options: internal, git, system
>
> That's what "git" means here.
"git" makes ./configure add capstone to GIT_SUBMODULES, and I'm
pretty sure we don't want that if we're not building from a git
tree.
--
Eduardo