Re: [Qemu-devel] [PATCH v3 05/13] target/i386: move cpu_tmp0 to DisasContext

[Richard Henderson]

On 09/11/2018 01:28 PM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/i386/translate.c | 282 ++++++++++++++++++++--------------------
>  1 file changed, 144 insertions(+), 138 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

I will note that these tmpN variables ought to be eliminated
completely, in favor of totally local temporary allocation.

But that should be done separately, because while they *ought*
to be local, in some cases it may be hard to see that they are.


r~