|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH V1 RESEND 1/6] hmat acpi: Build Memory Subsystem Address Range Structure(s) in ACPI HMAT |
Date: | Wed, 12 Sep 2018 09:33:46 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 7/16/18 6:54 AM, Igor Mammedov wrote:
+ +#include "unistd.h" +#include "fcntl.h" +#include "qemu/osdep.h" +#include "sysemu/numa.h" +#include "hw/i386/pc.h" +#include "hw/i386/acpi-build.h" +#include "hw/acpi/acpi.h" +#include "hw/acpi/hmat.h" +#include "hw/acpi/aml-build.h" +#include "hw/nvram/fw_cfg.h" +#include "hw/acpi/bios-linker-loader.h"Do all this headers are really needed here?
Furthermore, "qemu/osdep.h" MUST be listed first (as it may set macros that affect the content of other headers); "qemu/osdep.h" already takes care of including <unistd.h> and <fcntl.h>; and even if it hadn't, system headers should be spelled like <unistd.h> rather than "unistd.h".
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |