|
| From: | Eric Blake |
| Subject: | Re: [Qemu-devel] [PATCH 1/8] fw_cfg_mem: add read memory region callback |
| Date: | Wed, 12 Sep 2018 11:48:45 -0500 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/12/18 11:01 AM, Li Qiang wrote:
From: Li Qiang <address@hidden> Signed-off-by: Li Qiang <address@hidden>
This commit message doesn't state why. The cover letter does, but that doesn't get checked into git. A year from now, if someone lands on this commit during a bisect, it would help if the commit message told them why you are adding a no-op callback here, instead of trying to fix the caller to treat a NULL callback as acceptable.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |