Re: [Qemu-devel] [PATCH] input-linux: customizable grab toggle keys v3

[Gerd Hoffmann]

On Mon, Sep 03, 2018 at 04:32:10PM +0000, Ryan El Kochta wrote:
> This patch adds a new option to the input-linux object:
> 
> grab_toggle=key-key-key

"grab-toggle" (no underscore) please.

I'm still not convinced we need that much flexibility.
I would go for a fixed list of combinations.

Suggestion: add a enum to qapi (see QKeyCode in qapi/ui.json for an
example), that way you'll get a bunch of helper code and lookup tables
generated.  Simplifies the option parsing, you can use
object_property_add_enum() then.

> I have also attached the patch contained in the body of this email
> since my mail client does not seem to behave well with patches.
> If this is a problem, please let me know.

Using 'git send-email' is the best way to send out patch mails.

Must be set up once, but when done it is less work for both sending and
receiving side.

cheers,
  Gerd