Re: [Qemu-devel] [PATCH v2] change get_image_size return type to int64_t

[Eric Blake]

On 9/13/18 5:07 AM, Li Zhijian wrote:
> Previously, if the size of initrd >=2G, qemu exits with error:
> address@hidden:/home/lizj# 
> /home/lizhijian/lkp/qemu-colo/x86_64-softmmu/qemu-system-x86_64 -kernel 
> ./vmlinuz-4.16.0-rc4 -initrd large.cgz -nographic
> qemu: error reading initrd large.cgz: No such file or directory
> address@hidden:/home/lizj# du -sh large.cgz
> 2.5G    large.cgz
>
> this patch changes the caller side that use this function to calculate
> size of initrd file as well.
>
> v2: update error message and int64_t printing format

This v2 line is useful to reviewers, but makes no sense in long term git 
(a year from now, we won't care about how many versions it took or what 
had to be tweaked, only what got committed).  Thus, it belongs...

> Signed-off-by: Li Zhijian <address@hidden>
> ---

...here, after the --- separator, so that it is automatically stripped 
by 'git am' rather than requiring a maintainer to touch up your commit 
message.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org