[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw: edu: replace device name with macro
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] hw: edu: replace device name with macro |
Date: |
Fri, 14 Sep 2018 17:09:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 14/09/2018 07:11, Li Qiang wrote:
> Just as other devices do.
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
> hw/misc/edu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index df26a4d046..0687ffd343 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -30,7 +30,8 @@
> #include "qemu/main-loop.h" /* iothread mutex */
> #include "qapi/visitor.h"
>
> -#define EDU(obj) OBJECT_CHECK(EduState, obj, "edu")
> +#define TYPE_PCI_EDU_DEVICE "edu"
> +#define EDU(obj) OBJECT_CHECK(EduState, obj, TYPE_PCI_EDU_DEVICE)
>
> #define FACT_IRQ 0x00000001
> #define DMA_IRQ 0x00000100
> @@ -414,7 +415,7 @@ static void pci_edu_register_types(void)
> { },
> };
> static const TypeInfo edu_info = {
> - .name = "edu",
> + .name = TYPE_PCI_EDU_DEVICE,
> .parent = TYPE_PCI_DEVICE,
> .instance_size = sizeof(EduState),
> .instance_init = edu_instance_init,
>
Queued, thanks.
Paolo