[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] linux-user: do setrlimit selectively
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v3] linux-user: do setrlimit selectively |
Date: |
Tue, 18 Sep 2018 18:00:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Le 17/09/2018 à 20:13, Max Filippov a écrit :
> setrlimit guest calls that affect memory resources
> (RLIMIT_{AS,DATA,STACK}) may interfere with QEMU internal memory
> management. They may result in QEMU lockup because mprotect call in
> page_unprotect would fail with ENOMEM error code, causing infinite loop
> of SIGSEGV. E.g. it happens when running libstdc++ testsuite for xtensa
> target on x86_64 host.
>
> Don't call host setrlimit for memory-related resources.
>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Max Filippov <address@hidden>
> ---
> Changes v2->v3:
> - add comment sugessted by Peter
>
> Changes v1->v2:
> - don't limit change to 32-bit guest on 64-bit host case
>
> linux-user/syscall.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
rebased on master and applied on my branch linux-user-for-3.1
Thanks,
Laurent