Re: [Qemu-devel] [PATCH v9 8/9] qcow2: Set the default cache-clean-interval to 10 minutes

[Kevin Wolf]

Am 21.09.2018 um 14:35 hat Alberto Garcia geschrieben:
> On Tue 18 Sep 2018 05:29:22 PM CEST, Leonid Bloch wrote:
> >      /* New interval for cache cleanup timer */
> >      r->cache_clean_interval =
> >          qemu_opt_get_number(opts, QCOW2_OPT_CACHE_CLEAN_INTERVAL,
> > -                            s->cache_clean_interval);
> > +                            DEFAULT_CACHE_CLEAN_INTERVAL);
> 
> I just realized we're ignoring the old value (s->cache_clean_interval)
> here. What's the consequence of this? (this was a change made by Kevin
> Wolf in 5b0959a7d432062dcd740f8065004285b15695fa).

I think the consequence is that bdrv_reopen() will not keep the current
value if the option isn't given, but reset it to the default.

Kevin