[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype |
Date: |
Fri, 21 Sep 2018 16:09:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
>>>
>>> There is no such clash in VirtioPMemDeviceInfo. You could name the
>>> member "addr" there. But that would trade the inconsistency with
>>> PCDIMMDeviceInfo for an inconsistency with the device property.
>>>
>>> Is this correct?
>>>
>>
>> Yes, I chose to name it like the property. (that felt to be the right
>> thing). As far as I see this is perfectly fine.
>
> Now work that into the commit message or perhaps a comment, please :)
Yes, once this get's picked up in the !RFC version of virtio-pmem, we
should highlight that (and best, split VirtioPMemDeviceInfo introduction
off from the remaining part).
>
>> It's unfortunate but we
>> can't do anything about it.
>
> Well, if we really, really wanted to, we could: rename pc-dimm's
> property, keep the old name as a deprecated alias. Would that be better
> than the inconsistency, and the code you need to work around it? You
> decide.
>
I had the same in mind initially but considered it not useful right now.
There is not that much code to work around that (it's basically just two
functions get_addr() and set_addr() on the memory device interface), and
this way we can at least keep property setting/getting code out of
memory-device code (I don't consider properties useful when it comes to
internal interfaces).
If we ever see a problem with that, we can introduce the alias (+
optionally deprecate) later.
Thanks!
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v3 15/22] hw/acpi-build: only indicate nvdimm and pc-dimm, (continued)
- [Qemu-devel] [PATCH v3 15/22] hw/acpi-build: only indicate nvdimm and pc-dimm, David Hildenbrand, 2018/09/20
- [Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id(), David Hildenbrand, 2018/09/20
- [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Hildenbrand, 2018/09/20
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Markus Armbruster, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Hildenbrand, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Pankaj Gupta, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Markus Armbruster, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Hildenbrand, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, Markus Armbruster, 2018/09/21
- Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype,
David Hildenbrand <=
Re: [Qemu-devel] [PATCH v3 17/22] virtio-pmem: prototype, David Gibson, 2018/09/24
[Qemu-devel] [PATCH v3 18/22] virtio-pci: proxy for virtio-pmem, David Hildenbrand, 2018/09/20
[Qemu-devel] [PATCH v3 19/22] hmp: handle virtio-pmem when printing memory device infos, David Hildenbrand, 2018/09/20
[Qemu-devel] [PATCH v3 20/22] numa: handle virtio-pmem in NUMA stats, David Hildenbrand, 2018/09/20