[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v2 6/6] block/backup: prohibit backup from using
From: |
John Snow |
Subject: |
[Qemu-devel] [RFC PATCH v2 6/6] block/backup: prohibit backup from using in-use bitmaps |
Date: |
Fri, 21 Sep 2018 18:28:47 -0400 |
If the bitmap is locked, we shouldn't touch it.
Signed-off-by: John Snow <address@hidden>
---
blockdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 651c50d1fa..1f03db0c3c 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3435,10 +3435,10 @@ static BlockJob *do_drive_backup(DriveBackup *backup,
JobTxn *txn,
bdrv_unref(target_bs);
goto out;
}
- if (bdrv_dirty_bitmap_qmp_locked(bmap)) {
+ if (!bdrv_dirty_bitmap_user_modifiable(bmap)) {
error_setg(errp,
- "Bitmap '%s' is currently locked and cannot be used for
"
- "backup", backup->bitmap);
+ "Bitmap '%s' is currently in-use by another operation
and cannot be used for backup",
+ backup->bitmap);
goto out;
}
}
--
2.14.4
- [Qemu-devel] [RFC PATCH v2 0/6] dirty-bitmaps: fix QMP command permissions, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 1/6] dirty-bitmaps: allow merging to disabled bitmaps, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 2/6] bitmaps: allow clear on disabled bitmaps, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 3/6] bitmaps: prohibit merge on locked bitmaps, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 4/6] bitmaps: add user_modifiable status checker, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 5/6] bitmaps: prohibit enable/disable on locked/frozen bitmaps, John Snow, 2018/09/21
- [Qemu-devel] [RFC PATCH v2 6/6] block/backup: prohibit backup from using in-use bitmaps,
John Snow <=