[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] monitor: guard iothread access by mon->use_
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] monitor: guard iothread access by mon->use_io_thread |
Date: |
Tue, 25 Sep 2018 12:12:20 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Sep 21, 2018 at 10:28:55AM +0200, Wolfgang Bumiller wrote:
> monitor_resume() and monitor_suspend() both want to
> "kick" the I/O thread if it is there, but in
> monitor_suspend() lacked the use_io_thread flag condition.
> This is required when we later only spawn the thread on
> first use.
>
> Signed-off-by: Wolfgang Bumiller <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
> ---
> monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index 021c11b1bf..4802148c82 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4380,7 +4380,7 @@ int monitor_suspend(Monitor *mon)
>
> atomic_inc(&mon->suspend_cnt);
>
> - if (monitor_is_qmp(mon)) {
> + if (monitor_is_qmp(mon) && mon->use_io_thread) {
> /*
> * Kick I/O thread to make sure this takes effect. It'll be
> * evaluated again in prepare() of the watch object.
> --
> 2.11.0
>
>
Regards,
--
Peter Xu