Re: [Qemu-devel] [PATCH v3 2/3] gitmodules: add berkeley's softfloat + testfloat version 3

[Alex Bennée]

Emilio G. Cota <address@hidden> writes:

> These are BSD-licensed so we can add them as submodules.
>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  .gitmodules                   | 6 ++++++
>  tests/fp/berkeley-softfloat-3 | 1 +
>  tests/fp/berkeley-testfloat-3 | 1 +
>  3 files changed, 8 insertions(+)
>  create mode 160000 tests/fp/berkeley-softfloat-3
>  create mode 160000 tests/fp/berkeley-testfloat-3

I think you also need a configure tweak to help auto-checkout:

modified   configure
@@ -296,7 +296,7 @@ stack_protector=""
 if test -e "$source_path/.git"
 then
     git_update=yes
-    git_submodules="ui/keycodemapdb"
+    git_submodules="ui/keycodemapdb tests/fp/berkeley-testfloat-3 
tests/fp/berkeley-softfloat-3"
 else
     git_update=no
     git_submodules=""

>
> diff --git a/.gitmodules b/.gitmodules
> index d108478e0a..43920b9b90 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -43,3 +43,9 @@
>  [submodule "roms/u-boot-sam460ex"]
>       path = roms/u-boot-sam460ex
>       url = git://git.qemu.org/u-boot-sam460ex.git
> +[submodule "tests/fp/testfloat"]
> +     path = tests/fp/berkeley-testfloat-3
> +     url = git://github.com/cota/berkeley-testfloat-3
> +[submodule "tests/fp/berkeley-softfloat-3"]
> +     path = tests/fp/berkeley-softfloat-3
> +     url = git://github.com/cota/berkeley-softfloat-3
> diff --git a/tests/fp/berkeley-softfloat-3 b/tests/fp/berkeley-softfloat-3
> new file mode 160000
> index 0000000000..b64af41c32
> --- /dev/null
> +++ b/tests/fp/berkeley-softfloat-3
> @@ -0,0 +1 @@
> +Subproject commit b64af41c3276f97f0e181920400ee056b9c88037
> diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3
> new file mode 160000
> index 0000000000..ca9fa2ba05
> --- /dev/null
> +++ b/tests/fp/berkeley-testfloat-3
> @@ -0,0 +1 @@
> +Subproject commit ca9fa2ba05625ba929958f163b01747e07dd39cc

That said I'm getting:

  GIT     ui/keycodemapdb tests/fp/berkeley-testfloat-3 
tests/fp/berkeley-softfloat-3
error: Server does not allow request for unadvertised object 
ca9fa2ba05625ba929958f163b01747e07dd39cc
Fetched in submodule path 'tests/fp/berkeley-testfloat-3', but it did not 
contain ca9fa2ba05625ba929958f163b01747e07dd39cc. Direct fetching of that 
commit failed.
./scripts/git-submodule.sh: failed to update modules

But it looks like that is cached data in .git/modules from the last time
which seems particularly stubborn to excise...

--
Alex Bennée