[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fiel
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/scsi/mptendian: Avoid taking address of fields in packed structs |
|
Date: |
Fri, 28 Sep 2018 16:15:54 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, 09/27 14:48, Peter Maydell wrote:
> NB: tested with qemu-system-x86_64 -cpu host -enable-kvm -m 4096
> -device mptsas1068 -drive id=mydisk,if=none,file=harddisk.qcow2
> -device scsi-disk,drive=mydisk
> which behaves no differently before or after the patch, though
> the guest I have (an x86 ubuntu) seems to detect the controller
> but not find any disks attached to it. Maybe my command line is wrong?
But do you see a /dev/sda in guest (or does it boot at all)?
Anyway the patch looks correct, so
Reviewed-by: Fam Zheng <address@hidden>