[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus i
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method |
Date: |
Fri, 28 Sep 2018 17:13:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 28/09/2018 15:49, Cédric Le Goater wrote:
> Cc: Michael Walle <address@hidden>
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/net/milkymist-minimac2.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c
> index 3eaa19dfde92..5e7304a26a50 100644
> --- a/hw/net/milkymist-minimac2.c
> +++ b/hw/net/milkymist-minimac2.c
> @@ -452,9 +452,9 @@ static NetClientInfo net_milkymist_minimac2_info = {
> .receive = minimac2_rx,
> };
>
> -static int milkymist_minimac2_init(SysBusDevice *sbd)
> +static void milkymist_minimac2_realize(DeviceState *dev, Error **errp)
> {
> - DeviceState *dev = DEVICE(sbd);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> MilkymistMinimac2State *s = MILKYMIST_MINIMAC2(dev);
> size_t buffers_size = TARGET_PAGE_ALIGN(3 * MINIMAC2_BUFFER_SIZE);
>
> @@ -479,8 +479,6 @@ static int milkymist_minimac2_init(SysBusDevice *sbd)
> s->nic = qemu_new_nic(&net_milkymist_minimac2_info, &s->conf,
> object_get_typename(OBJECT(dev)), dev->id, s);
> qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a);
> -
> - return 0;
> }
>
> static const VMStateDescription vmstate_milkymist_minimac2_mdio = {
> @@ -521,9 +519,8 @@ static Property milkymist_minimac2_properties[] = {
> static void milkymist_minimac2_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>
> - k->init = milkymist_minimac2_init;
> + dc->realize = milkymist_minimac2_realize;
> dc->reset = milkymist_minimac2_reset;
> dc->vmsd = &vmstate_milkymist_minimac2;
> dc->props = milkymist_minimac2_properties;
>
- Re: [Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method, (continued)
- [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28