Re: [Qemu-devel] [PATCH v2 00/12] Various qemu command line options help improvements

[Marc-André Lureau]

Hi

On Tue, Sep 11, 2018 at 5:17 PM Paolo Bonzini <address@hidden> wrote:
>
> On 07/09/2018 09:59, Marc-André Lureau wrote:
> > Hi,
> >
> > This is a compilation of patches I have to improve command line help
> > support. The "qemu-option" patches have already been sent earlier, I
> > modified the first to fix an issue reported by Markus. The other
> > patches add support for -object help. A few related patches for QOM,
> > to fix/improve some minor issues.
> >
> > v2: after Eric Blake review
> > - add "qdev-monitor: print help to stdout"
> > - add "cutils: add qemu_pstrcmp"
> > - use consistently "arg=type - desc" help format
>
> Feel free to send a pull request yourself with the minor fixes requested
> during review.

It would be nice to get some more review before :)

Andreas, as QOM maintainer, do you have time to take a look?

Anybody else interested to improve the CLI?

thanks

> Paolo
>
> > Marc-André Lureau (12):
> >   qdev-monitor: print help to stdout
> >   cutils: add qemu_pstrcmp
> >   qemu-option: add help fallback to print the list of options
> >   qemu-option: improve qemu_opts_print_help() output
> >   qom/object: fix iterating properties over a class
> >   qom/object: register 'type' property as class property
> >   tests/qom-proplist: check duplicate "bv" property registration failed
> >   tests/qom-proplist: check properties are not listed multiple times
> >   tests/qom-proplist: check class properties iterator
> >   vl: handle -object help
> >   hostmem: add some properties description
> >   vl: list user creatable properties when 'help' is argument
> >
> >  include/monitor/monitor.h  |  2 ++
> >  include/qemu/cutils.h      | 12 +++++++
> >  backends/hostmem-memfd.c   |  9 +++++
> >  backends/hostmem.c         | 14 ++++++++
> >  monitor.c                  | 16 +++++++--
> >  qdev-monitor.c             | 32 ++++++++++-------
> >  qom/object.c               |  9 ++---
> >  qom/object_interfaces.c    |  6 ++--
> >  tests/check-qom-proplist.c | 58 ++++++++++++++++++++-----------
> >  util/cutils.c              |  5 +++
> >  util/qemu-option.c         | 71 +++++++++++++++++++++++++++++++-------
> >  vl.c                       | 53 ++++++++++++++++++++++++++--
> >  12 files changed, 227 insertions(+), 60 deletions(-)
> >
>
>


-- 
Marc-André Lureau