[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] hw/timer/sun4v-rtc: Use DeviceState::real
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH 03/15] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init |
Date: |
Tue, 2 Oct 2018 17:49:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/2/18 12:09 AM, Philippe Mathieu-Daudé wrote:
> Move from the legacy SysBusDevice::init method to using DeviceState::realize.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
> ---
> hw/timer/sun4v-rtc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/timer/sun4v-rtc.c b/hw/timer/sun4v-rtc.c
> index 13be94f8da..4e7f6a1eff 100644
> --- a/hw/timer/sun4v-rtc.c
> +++ b/hw/timer/sun4v-rtc.c
> @@ -63,21 +63,21 @@ void sun4v_rtc_init(hwaddr addr)
> sysbus_mmio_map(s, 0, addr);
> }
>
> -static int sun4v_rtc_init1(SysBusDevice *dev)
> +static void sun4v_rtc_realize(DeviceState *dev, Error **errp)
> {
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
> Sun4vRtc *s = SUN4V_RTC(dev);
>
> memory_region_init_io(&s->iomem, OBJECT(s), &sun4v_rtc_ops, s,
> "sun4v-rtc", 0x08ULL);
> - sysbus_init_mmio(dev, &s->iomem);
> - return 0;
> + sysbus_init_mmio(sbd, &s->iomem);
> }
>
> static void sun4v_rtc_class_init(ObjectClass *klass, void *data)
> {
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
> + DeviceClass *dc = DEVICE_CLASS(klass);
>
> - k->init = sun4v_rtc_init1;
> + dc->realize = sun4v_rtc_realize;
> }
>
> static const TypeInfo sun4v_rtc_info = {
>
- Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init, (continued)
Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init, Cédric Le Goater, 2018/10/02
[Qemu-devel] [PATCH 07/15] hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 03/15] hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 02/15] hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 01/15] trace-events: Fix copy/paste typo, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 12/15] hw/core: Remove the 'empty_slot' device, Philippe Mathieu-Daudé, 2018/10/01
[Qemu-devel] [PATCH 11/15] hw/sparc/sun4m: Replace 'empty_slot' by 'unimplemented_device', Philippe Mathieu-Daudé, 2018/10/01