Re: [Qemu-devel] [PATCH v2 09/12] tests/qom-proplist: check class properties iterator

[Paolo Bonzini]

On 07/09/2018 09:59, Marc-André Lureau wrote:
> This test failed before "fix iterating properties over a class".
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/check-qom-proplist.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
> index 8e1b9c27f3..7ed16b704b 100644
> --- a/tests/check-qom-proplist.c
> +++ b/tests/check-qom-proplist.c
> @@ -565,6 +565,14 @@ static void test_dummy_iterator(void)
>      object_unparent(OBJECT(dobj));
>  }
>  
> +static void test_dummy_class_iterator(void)
> +{
> +    ObjectPropertyIterator iter;
> +    ObjectClass *klass = object_class_by_name(TYPE_DUMMY);
> +
> +    object_class_property_iter_init(&iter, klass);
> +    test_dummy_prop_iterator(&iter);
> +}
>  
>  static void test_dummy_delchild(void)
>  {
> @@ -636,6 +644,7 @@ int main(int argc, char **argv)
>      g_test_add_func("/qom/proplist/badenum", test_dummy_badenum);
>      g_test_add_func("/qom/proplist/getenum", test_dummy_getenum);
>      g_test_add_func("/qom/proplist/iterator", test_dummy_iterator);
> +    g_test_add_func("/qom/proplist/class_iterator", 
> test_dummy_class_iterator);
>      g_test_add_func("/qom/proplist/delchild", test_dummy_delchild);
>      g_test_add_func("/qom/resolve/partial", test_qom_partial_path);
>  
> 

Reviewed-by: Paolo Bonzini <address@hidden>