Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64

[Thomas Huth]

On 2018-10-04 15:48, Andrew Jones wrote:
> On Fri, Sep 28, 2018 at 03:47:35PM -0400, Wei Huang wrote:
[...]
>> diff --git a/tests/migration/aarch64/Makefile 
>> b/tests/migration/aarch64/Makefile
>> new file mode 100644
>> index 0000000..d440fa8
>> --- /dev/null
>> +++ b/tests/migration/aarch64/Makefile
>> @@ -0,0 +1,20 @@
>> +# To specify cross compiler prefix, use CROSS_PREFIX=
>> +#   $ make CROSS_PREFIX=aarch64-linux-gnu-
>> +
>> +.PHONY: all clean
>> +all: a-b-kernel.h
>> +
>> +a-b-kernel.h: aarch64.kernel
>> +    echo "$$__note" > header.tmp
>> +    xxd -i $< | sed -e 's/.*int.*//' >> header.tmp
>> +    mv header.tmp $@
>> +
>> +aarch64.kernel: aarch64.elf
>> +    $(CROSS_PREFIX)objcopy -O binary $< $@
>> +
>> +aarch64.elf: a-b-kernel.S
>> +    $(CROSS_PREFIX)gcc -o $@ -nostdlib -Wl,--build-id=none $<
>> +
>> +clean:
>> +    @rm -rf *.kernel *.elf
> 
> I don't think we need/want '-f'. Why not use $(RM)?

Does $(RM) work now in the QEMU Makefiles? AFAIK we are disabling the
standard variables in rules.mak ("MAKEFLAGS += -rR"), but never set RM
again...

 Thomas