[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] Acceptance Tests: improve docstring on pick
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] Acceptance Tests: improve docstring on pick_default_qemu_bin() |
Date: |
Fri, 5 Oct 2018 17:24:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 04/10/2018 17:14, Cleber Rosa wrote:
> Making it clear what is returned by this utility function.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py
> b/tests/acceptance/avocado_qemu/__init__.py
> index 1e54fd5932..d8d5b48dac 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -27,6 +27,10 @@ def pick_default_qemu_bin():
> """
> Picks the path of a QEMU binary, starting either in the current working
> directory or in the source tree root directory.
> +
> + :returns: the path to the default QEMU binary or None if one could not
> + be found
> + :rtype: str or None
> """
> arch = os.uname()[4]
> qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
>
- [Qemu-devel] [PATCH 0/7] Acceptance Tests: basic architecture support, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 1/7] Acceptance Tests: improve docstring on pick_default_qemu_bin(), Cleber Rosa, 2018/10/04
- Re: [Qemu-devel] [PATCH 1/7] Acceptance Tests: improve docstring on pick_default_qemu_bin(),
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 2/7] Acceptance Tests: introduce arch parameter and attribute, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 3/7] scripts/qemu.py: add method and private attribute for arch, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 4/7] scripts/qemu.py: set predefined machine type based on arch, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 5/7] Acceptance Tests: set machine type, Cleber Rosa, 2018/10/04
- [Qemu-devel] [PATCH 6/7] Acceptance Tests: add variants definition for architectures, Cleber Rosa, 2018/10/04