[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/31] numa: Clean up error reporting in parse_n
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 25/31] numa: Clean up error reporting in parse_numa() |
|
Date: |
Mon, 8 Oct 2018 15:01:42 -0300 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Mon, Oct 08, 2018 at 07:31:19PM +0200, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. parse_numa() does that, and then fails without setting
> an error. Its caller main(), via qemu_opts_foreach(), is fine with
> it, but clean it up anyway.
>
> While there, give parse_numa() internal linkage.
>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Queueing on machine-next. Thanks!
--
Eduardo
- Re: [Qemu-devel] [PATCH 03/31] cpus hw target: Use warn_report() & friends to report warnings, (continued)
- [Qemu-devel] [PATCH 31/31] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 14/31] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 25/31] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/08
- Re: [Qemu-devel] [PATCH 25/31] numa: Clean up error reporting in parse_numa(),
Eduardo Habkost <=
- [Qemu-devel] [PATCH 01/31] Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 05/31] vfio: Clean up error reporting after previous commit, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 04/31] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 20/31] vl: Clean up error reporting in machine_set_property(), Markus Armbruster, 2018/10/08