[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v11 07/31] iotests.py: Add node_inf
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v11 07/31] iotests.py: Add node_info() |
Date: |
Mon, 8 Oct 2018 15:59:25 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/08/2018 03:57 PM, Max Reitz wrote:
> On 08.10.18 21:34, John Snow wrote:
>>
>>
>> On 10/05/2018 07:39 PM, Max Reitz wrote:
>>> This function queries a node; since we cannot do that right now, it
>>> executes query-named-block-nodes and returns the matching node's object.
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>>> ---
>>> tests/qemu-iotests/iotests.py | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
>>> index 5c45788dac..604f200600 100644
>>> --- a/tests/qemu-iotests/iotests.py
>>> +++ b/tests/qemu-iotests/iotests.py
>>> @@ -465,6 +465,13 @@ class VM(qtest.QEMUQtestMachine):
>>> else:
>>> iotests.log(ev)
>>>
>>> + def node_info(self, node_name):
>>> + nodes = self.qmp('query-named-block-nodes')
>>> + for x in nodes['return']:
>>> + if x['node-name'] == node_name:
>>> + return x
>>> + return None
>>> +
>>>
>>> index_re = re.compile(r'([^\[]+)\[([^\]]+)\]')
>>>
>>>
>>
>> Reviewed-by: John Snow <address@hidden>
>>
>> Do we ever want to revisit the idea that our API should not do any
>> pre-filtering and that it's always up to the client to do so?
>
> I mean we certainly want to revisit the idea that we should have a
> proper query API.
>
> But what exactly do you mean by pre-filtering?
>
> Max
>
i.e. applying selection criteria before responding to the query. e.g.,
by looking for matches on node-name.
(Did I use i.e. and e.g. right?)
--js
- [Qemu-devel] [PATCH v11 00/31] block: Fix some filename generation issues, Max Reitz, 2018/10/05
- [Qemu-devel] [PATCH v11 01/31] block: Use bdrv_refresh_filename() to pull, Max Reitz, 2018/10/05
- [Qemu-devel] [PATCH v11 02/31] block: Use children list in bdrv_refresh_filename, Max Reitz, 2018/10/05
- [Qemu-devel] [PATCH v11 05/31] block: Respect backing bs in bdrv_refresh_filename, Max Reitz, 2018/10/05
- [Qemu-devel] [PATCH v11 04/31] block: Add BDS.auto_backing_file, Max Reitz, 2018/10/05
- [Qemu-devel] [PATCH v11 07/31] iotests.py: Add node_info(), Max Reitz, 2018/10/05
- Re: [Qemu-devel] [PATCH v11 07/31] iotests.py: Add node_info(), Alberto Garcia, 2018/10/09
[Qemu-devel] [PATCH v11 08/31] iotests: Add test for backing file overrides, Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 06/31] iotests.py: Add filter_imgfmt(), Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 09/31] block: Make path_combine() return the path, Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val., Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 12/31] block: Add bdrv_make_absolute_filename(), Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 16/31] quorum: Make bdrv_dirname() return NULL, Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 13/31] block: Fix bdrv_find_backing_image(), Max Reitz, 2018/10/05
[Qemu-devel] [PATCH v11 11/31] block: bdrv_get_full_backing_filename's ret. val., Max Reitz, 2018/10/05