|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 29/31] vl: Assert drive_new() does not fail in default_drive() |
Date: | Mon, 8 Oct 2018 15:48:49 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/8/18 12:31 PM, Markus Armbruster wrote:
If creating (empty) default drives fails, it's a bug. Therefore, assert() is more appropriate than exit(1). Cc: Kevin Wolf <address@hidden> Cc: Max Reitz <address@hidden> Signed-off-by: Markus Armbruster <address@hidden> --- vl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
The assert disappears in the next patch (replaced by an &error_fatal), but the separation of patches makes sense.
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |