Re: [Qemu-devel] [PATCH v2] linux-user: Suppress address-of-packed-member warnings in __get/put_user_e

[Peter Maydell]

On 9 October 2018 at 17:22, Laurent Vivier <address@hidden> wrote:
> Le 09/10/2018 à 18:18, Peter Maydell a écrit :
>> +#ifdef __clang__
>> +#define PRAGMA_DISABLE_PACKED_WARNING                                   \
>> +    _Pragma("GCC diagnostic push");                                     \
>> +    _Pragma("GCC diagnostic ignored \"-Wpragmas\"");                    \
>
> Do we really need this pragma now we don't build this for gcc?
> I understood it was for older gcc, not older llvm.

Yes, it's necessary. Older versions of clang don't recognize
-Waddress-of-packed-member.

thanks
-- PMM