Re: [Qemu-devel] [PATCH v5 1/6] target/alpha: remove tlb_flush from alpha_cpu_initfn

[Richard Henderson]

On 10/9/18 11:25 AM, Peter Maydell wrote:
>>         /* PALBR */
>>         tcg_gen_st_i64(vb, cpu_env, offsetof(CPUAlphaState, palbr));
>>         /* Changing the PAL base register implies un-chaining all of the TBs
>>            that ended with a CALL_PAL.  Since the base register usually only
>>            changes during boot, flushing everything works well.  */
>>         gen_helper_tb_flush(cpu_env);
>>         return DISAS_PC_STALE;
> 
> Mmm, it works (though would it work if the CPU wasn't the
> only one in the system?). I just have a reflexive dislike
> of design approaches used by only one thing -- I tend to
> like to smooth them out so there's more consistency...

It could be less important now that we have goto_ptr.
If you really think I should get rid of it, I will.


r~