Re: [Qemu-devel] [PATCH 3/3] memory-mapping: skip non-volatile memory regions in GuestPhysBlockList

[Dr. David Alan Gilbert]

* Laszlo Ersek (address@hidden) wrote:
> On 10/03/18 13:44, Marc-André Lureau wrote:
> > GuestPhysBlockList is currently used to produce dumps. Given the size
> > and the typical usage of NVDIMM for storage, they are not a good idea
> > to have in the dumps. We may want to have an extra dump option to
> > include them. For now, skip non-volatile regions.
> > 
> > The TCG memory clear function is going to use the GuestPhysBlockList
> > as well, and will thus skip NVDIMM for similar reasons.
> > 
> > Cc: address@hidden
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> >  memory_mapping.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/memory_mapping.c b/memory_mapping.c
> > index 775466f3a8..724dd0b417 100644
> > --- a/memory_mapping.c
> > +++ b/memory_mapping.c
> > @@ -206,7 +206,8 @@ static void guest_phys_blocks_region_add(MemoryListener 
> > *listener,
> >  
> >      /* we only care about RAM */
> >      if (!memory_region_is_ram(section->mr) ||
> > -        memory_region_is_ram_device(section->mr)) {
> > +        memory_region_is_ram_device(section->mr) ||
> > +        memory_region_is_nonvolatile(section->mr)) {
> >          return;
> >      }
> >  
> > 
> 
> I've peeked at the first two patches as well. Seems OK to me. (Famous
> last words?)
> 
> Reviewed-by: Laszlo Ersek <address@hidden>

This also looks good to me; just cc'ing in David H as well though.

Dave

--
Dr. David Alan Gilbert / address@hidden / Manchester, UK