[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/i386: Remove #ifdeffed-out icebp debuggi
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/i386: Remove #ifdeffed-out icebp debugging hack |
|
Date: |
Wed, 10 Oct 2018 07:22:43 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/9/18 11:33 AM, Peter Maydell wrote:
> Remove a debugging hack which could be used to cause the
> undocumented 'icebp' instruction to enable QEMU internal
> debug logging. This code has always been #ifdeffed out
> since it was introduced in commit aba9d61e34b9 in 2005;
> judging by the rest of that commit (which is entirely
> unrelated) it may have even been committed by accident.
>
> (Note that WANT_ICEBP is not defined by default anyway.)
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> Mostly I wanted to get rid of the weird call to tb_flush(),
> which is a bit unexpected to find in target frontend code.
>
> target/i386/translate.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~