[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] audio: use TYPE_WM8750 instead of a hardcod
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] audio: use TYPE_WM8750 instead of a hardcoded string |
|
Date: |
Thu, 11 Oct 2018 12:40:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 11/10/2018 11:00, Mao Zhongyi wrote:
> Cc: Jan Kiszka <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> To: address@hidden
>
> Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/musicpal.c | 2 +-
> hw/audio/marvell_88w8618.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index c807010e83..3dafb41b0b 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -1695,7 +1695,7 @@ static void musicpal_init(MachineState *machine)
> wm8750_dev = i2c_create_slave(i2c, TYPE_WM8750, MP_WM_ADDR);
> dev = qdev_create(NULL, "mv88w8618_audio");
> s = SYS_BUS_DEVICE(dev);
> - qdev_prop_set_ptr(dev, "wm8750", wm8750_dev);
> + qdev_prop_set_ptr(dev, TYPE_WM8750, wm8750_dev);
> qdev_init_nofail(dev);
> sysbus_mmio_map(s, 0, MP_AUDIO_BASE);
> sysbus_connect_irq(s, 0, pic[MP_AUDIO_IRQ]);
> diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
> index e546892d3c..cf6ce6979b 100644
> --- a/hw/audio/marvell_88w8618.c
> +++ b/hw/audio/marvell_88w8618.c
> @@ -280,7 +280,7 @@ static const VMStateDescription mv88w8618_audio_vmsd = {
> };
>
> static Property mv88w8618_audio_properties[] = {
> - DEFINE_PROP_PTR("wm8750", mv88w8618_audio_state, wm),
> + DEFINE_PROP_PTR(TYPE_WM8750, mv88w8618_audio_state, wm),
> {/* end of list */},
> };
>
>