[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 6/7] memory-device: avoid overflows on very huge
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v2 6/7] memory-device: avoid overflows on very huge devices |
Date: |
Fri, 12 Oct 2018 13:49:15 +0200 |
Should not be a problem right now, but it could theoretically happen
in the future.
Signed-off-by: David Hildenbrand <address@hidden>
---
hw/mem/memory-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 996ad1490f..8be63c8032 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -85,7 +85,8 @@ static void memory_device_check_addable(MachineState *ms,
uint64_t size,
/* will we exceed the total amount of memory specified */
memory_device_used_region_size(OBJECT(ms), &used_region_size);
- if (used_region_size + size > ms->maxram_size - ms->ram_size) {
+ if (used_region_size + size < used_region_size ||
+ used_region_size + size > ms->maxram_size - ms->ram_size) {
error_setg(errp, "not enough space, currently 0x%" PRIx64
" in use of total space for memory devices 0x" RAM_ADDR_FMT,
used_region_size, ms->maxram_size - ms->ram_size);
--
2.17.1
- [Qemu-devel] [PATCH v2 0/7] qapi/range/memory-device: fixes and cleanups, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 1/7] qapi: correctly parse uint64_t values from strings, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 2/7] qapi: use qemu_strtoi64() in parse_str_int64, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 3/7] range: pass const pointer where possible, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 4/7] range: add some more functions, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 5/7] memory-device: use QEMU_IS_ALIGNED, David Hildenbrand, 2018/10/12
- [Qemu-devel] [PATCH v2 6/7] memory-device: avoid overflows on very huge devices,
David Hildenbrand <=
- [Qemu-devel] [PATCH v2 7/7] memory-device: rewrite address assignment using ranges, David Hildenbrand, 2018/10/12