[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 24/26] net: ignore packet size greater than INT_MAX
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 24/26] net: ignore packet size greater than INT_MAX |
Date: |
Mon, 15 Oct 2018 16:46:24 +0800 |
There should not be a reason for passing a packet size greater than
INT_MAX. It's usually a hint of bug somewhere, so ignore packet size
greater than INT_MAX in qemu_deliver_packet_iov()
CC: address@hidden
Reported-by: Daniel Shapira <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
net/net.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index c66847e..07c194a 100644
--- a/net/net.c
+++ b/net/net.c
@@ -712,10 +712,15 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
void *opaque)
{
NetClientState *nc = opaque;
+ size_t size = iov_size(iov, iovcnt);
int ret;
+ if (size > INT_MAX) {
+ return size;
+ }
+
if (nc->link_down) {
- return iov_size(iov, iovcnt);
+ return size;
}
if (nc->receive_disabled) {
--
2.5.0
- [Qemu-devel] [PULL 03/26] colo-compare: use notifier to notify packets comparing result, (continued)
- [Qemu-devel] [PULL 03/26] colo-compare: use notifier to notify packets comparing result, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 15/26] filter: Add handle_event method for NetFilterClass, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 19/26] docs: Add COLO status diagram to COLO-FT.txt, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 13/26] savevm: split the process of different stages for loadvm/savevm, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 12/26] qapi: Add new command to query colo status, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 17/26] COLO: notify net filters about checkpoint/failover event, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 07/26] COLO: Load dirty pages into SVM's RAM cache firstly, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 20/26] clean up callback when del virtqueue, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 06/26] COLO: Remove colo_state migration struct, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 22/26] rtl8139: fix possible out of bound access, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 24/26] net: ignore packet size greater than INT_MAX,
Jason Wang <=
- [Qemu-devel] [PULL 16/26] filter-rewriter: handle checkpoint and failover event, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 21/26] ne2000: fix possible out of bound access in ne2000_receive, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 25/26] e1000: indicate dropped packets in HW counters, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 23/26] pcnet: fix possible buffer overflow, Jason Wang, 2018/10/15
- [Qemu-devel] [PULL 26/26] qemu-options: Fix bad "macaddr" property in the documentation, Jason Wang, 2018/10/15
- Re: [Qemu-devel] [PULL 00/26] Net patches, Peter Maydell, 2018/10/15