Re: [Qemu-devel] [PATCH] target/mips: Fix misplaced 'break' in NM_SHRA_R_PH handling

[Aleksandar Markovic]

> From: Aleksandar Markovic <address@hidden>
> Sent: Tuesday, October 16, 2018 4:46 PM
> To: address@hidden
> Cc: address@hidden; Aleksandar Markovic; Stefan Markovic; Petar Jovanovic; > 
> address@hidden
> Subject: [PATCH] target/mips: Fix misplaced 'break' in NM_SHRA_R_PH handling
> 
> From: Stefan Markovic <address@hidden>
> 
> Fix misplaced 'break' in handling of NM_SHRA_R_PH. Found by
> Coverity (CID 1395627).
> 
> Signed-off-by: Stefan Markovic <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  target/mips/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Aleksandar Markovic <address@hidden>

> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index faf05ae..e93c6f9 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -19991,8 +19991,8 @@ static void gen_pool32a5_nanomips_insn(DisasContext 
> *ctx, int > opc,
>          case 0:
>              /* SHRA_PH */
>              gen_helper_shra_ph(v1_t, t0, v1_t);
> -            break;
>              gen_store_gpr(v1_t, rt);
> +            break;
>          case 1:
>              /* SHRA_R_PH */
>              gen_helper_shra_r_ph(v1_t, t0, v1_t);
> --
> 2.7.4
> 
>