[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 35/38] vl: Simplify call of parse_name()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 35/38] vl: Simplify call of parse_name() |
Date: |
Tue, 16 Oct 2018 19:41:55 +0200 |
main() checks for parse_name() failure even though it can't actually
fail. That's okay. Simplify it to check by passing &error_fatal,
like the other users of qemu_opts_foreach().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
vl.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 89520d8007..01d71371c2 100644
--- a/vl.c
+++ b/vl.c
@@ -3973,10 +3973,8 @@ int main(int argc, char **argv, char **envp)
}
#endif
- if (qemu_opts_foreach(qemu_find_opts("name"),
- parse_name, NULL, NULL)) {
- exit(1);
- }
+ qemu_opts_foreach(qemu_find_opts("name"),
+ parse_name, NULL, &error_fatal);
#ifndef _WIN32
qemu_opts_foreach(qemu_find_opts("add-fd"),
--
2.17.1
- [Qemu-devel] [PATCH v3 19/38] qom: Clean up error reporting in user_creatable_add_opts_foreach(), (continued)
- [Qemu-devel] [PATCH v3 19/38] qom: Clean up error reporting in user_creatable_add_opts_foreach(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 17/38] seccomp: Clean up error reporting in parse_sandbox(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 37/38] raw: Convert a warning to warn_report(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 36/38] block: Clean up bdrv_img_create()'s error reporting, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 27/38] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 26/38] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 31/38] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 35/38] vl: Simplify call of parse_name(),
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 25/38] ui/keymaps: Fix handling of erroneous include files, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 33/38] blockdev: Convert drive_new() to Error, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 30/38] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 04/38] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 34/38] vl: Fix exit status for -drive format=help, Markus Armbruster, 2018/10/16
- [Qemu-devel] [PATCH v3 28/38] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/16