Re: [Qemu-devel] [PATCH v3 4/4] MAINTAINERS: Voluntary to review hobbyist MIPS contributions

[Philippe Mathieu-Daudé]

Hi Aleksandar,

On Wed, Oct 17, 2018 at 2:15 PM Aleksandar Markovic
<address@hidden> wrote:
> > From: Philippe Mathieu-Daudé <address@hidden> on behalf of Philippe 
> > Mathieu-Daudé <address@hidden>
> > Subject: [PATCH v3 4/4] MAINTAINERS: Voluntary to review hobbyist MIPS 
> > contributions
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
>
> This is very generous of you. However, I would prefer registered reviewers of 
> MIPS directories to be persons more focused on MIPS. But thanks again.

In MAINTAINERS the 'R:' tag simply means "These reviewers should be
CCed on patches."

This is just used by the get_maintainer script to see to who send patches to.
This is not about responsibility nor ownership.

The guideline on the wiki
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
says:
  "In fact, you can automate this, via a one-time setup of git config
sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'."

So you end up with:

$ grep -A2 email .git/config
[sendemail]
    confirm = auto
    cccmd = scripts/get_maintainer.pl --nogit-fallback --noroles --n
--m --r --remove-duplicates

As an example, if you check the "Unimp device" section:

Unimplemented device
M: Peter Maydell <address@hidden>
R: Philippe Mathieu-Daudé <address@hidden>
S: Maintained
F: include/hw/misc/unimp.h
F: hw/misc/unimp.c

I'm not a maintainer, Peter is. I have no obligation to review
patches, I am simply interested to not loose them in the traffic.
With the 'R:' tag my email appears in the list:

$ ./scripts/get_maintainer.pl -f hw/misc/unimp.c
Peter Maydell <address@hidden> (maintainer:Unimplemented device)
"Philippe Mathieu-Daudé" <address@hidden> (reviewer:Unimplemented device)
address@hidden (open list:All patches CC here)

Anyway I'm fine with that patch not being applied, and now I even
prefer it is not.

I found a kludge using the "to: (address@hidden
address@hidden address@hidden)" email filter. If an
email is sent to the list and both of you, it is very likely this is
MIPS related.

Regards,

Phil.