Re: [Qemu-devel] [PATCH v4 36/38] block: Clean up bdrv_img_create()'s error reporting

[Kevin Wolf]

Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben:
> bdrv_img_create() takes an Error ** argument and uses it in the
> conventional way, except for one place: when qemu_opts_do_parse()
> fails, it first reports its error to stderr or the HMP monitor with
> error_report_err(), then error_setg()'s a generic error.
> 
> When the caller reports that second error similarly, this produces two
> consecutive error messages on stderr or the HMP monitor.
> 
> When the caller does something else with it, such as send it via QMP,
> the first error still goes to stderr or the HMP monitor.  Fortunately,
> no such caller exists.
> 
> Simply use the first error as is.  Update expected output of
> qemu-iotest 049 accordingly.
> 
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>